DRY out sting naming

linkedin · Dec 19, 2024 · d4a02d3 · d4a02d3
1 parent 4e5025d
commit d4a02d3
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java b/services/venice-router/src/main/java/com/linkedin/venice/router/MetaDataHandler.java
@@ -158,7 +158,6 @@ public class MetaDataHandler extends SimpleChannelInboundHandler<HttpRequest> {
   static final String REQUEST_BLOB_DISCOVERY_ERROR_PUSH_STORE =
       "Blob Discovery: failed to get the live node hostNames for store:%s version:%s partition:%s";
   private final VeniceVersionFinder veniceVersionFinder;
-
   private final MetricsRepository metricsRepository;
 
   public MetaDataHandler(
@@ -485,8 +484,9 @@ private void handleD2ServiceLookup(ChannelHandlerContext ctx, VenicePathParserHe
     }
 
     // Only create metrics for valid stores
-    Sensor d2DiscoverySensor = metricsRepository.sensor(String.format("venice.router.d2_discovery.%s", storeName));
-    d2DiscoverySensor.add(String.format("venice.router.d2_discovery.%s.request.count", storeName), new Count());
+    String d2DiscoveryMetricName = "venice.router.d2_discovery." + storeName;
+    Sensor d2DiscoverySensor = metricsRepository.sensor(d2DiscoveryMetricName);
+    d2DiscoverySensor.add(d2DiscoveryMetricName + ".request.count", new Count());
     d2DiscoverySensor.record();
 
     String clusterName = config.get().getCluster();