[vpj][controller] Add deferred swap for target region push #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majisourav99
reviewed
Dec 9, 2024
internal/venice-common/src/main/java/com/linkedin/venice/meta/Store.java
Show resolved
Hide resolved
majisourav99
reviewed
Dec 9, 2024
clients/venice-push-job/src/main/java/com/linkedin/venice/vpj/VenicePushJobConstants.java
Outdated
Show resolved
Hide resolved
...ces/venice-controller/src/main/java/com/linkedin/venice/pushmonitor/AbstractPushMonitor.java
Show resolved
Hide resolved
...ces/venice-controller/src/main/java/com/linkedin/venice/pushmonitor/AbstractPushMonitor.java
Outdated
Show resolved
Hide resolved
...ice-test-common/src/integrationTest/java/com/linkedin/venice/endToEnd/DaVinciClientTest.java
Outdated
Show resolved
Hide resolved
...ces/venice-controller/src/main/java/com/linkedin/venice/pushmonitor/AbstractPushMonitor.java
Outdated
Show resolved
Hide resolved
...ces/venice-controller/src/main/java/com/linkedin/venice/pushmonitor/AbstractPushMonitor.java
Outdated
Show resolved
Hide resolved
clients/venice-push-job/src/main/java/com/linkedin/venice/hadoop/VenicePushJob.java
Show resolved
Hide resolved
majisourav99
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary, imperative, start upper case, don't end with a period
Currently, when target region push is enabled, it only ingests the data & swap to the new version in if the current region matches the target region defined by the target region push list or the native replication source fabric. The ingestion for the remaining regions are kicked off after the first region is able to swap to the new version.
The pr adds in a deferred version swap option to the existing target region push. In this version, data is ingested in all regions, but it will only swap to the new version in the target region. The behavior to swap the version out in the remaining regions will be added in later.
How was this PR tested?
unit & integration tests
Does this PR introduce any user-facing changes?
This will be enabled if
targeted.region.push.with.deferred.swapis passed in in the job settings