[server] Fix stats handling for SINGLE_GET requests #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
reviewed
Dec 10, 2024
services/venice-server/src/main/java/com/linkedin/venice/stats/ServerHttpRequestStats.java
Outdated
Show resolved
Hide resolved
nisargthakkar
force-pushed
the
fixMissingMetricsForSingleGet
branch
from
87cfcdd to
8d6b2a9
Compare
2 tasks
nisargthakkar
force-pushed
the
fixMissingMetricsForSingleGet
branch
from
701ce46 to
b98e153
Compare
sushantmane
reviewed
Dec 10, 2024
services/venice-server/src/main/java/com/linkedin/venice/stats/ServerHttpRequestStats.java
Show resolved
Hide resolved
sushantmane
reviewed
Dec 10, 2024
...ces/venice-server/src/test/java/com/linkedin/venice/stats/AggServerHttpRequestStatsTest.java
Outdated
Show resolved
Hide resolved
sushantmane
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stats handling for
SINGLE_GETrequestsIn a previous commit (#1377), when removing some metrics, we ended up removing some key metrics about key and value size values for single_get requests as well. That change also led to NPEs as the caller expected the K/V stats to always be recorded for Single-get requests. This commit adds
AvgandMaxstats by default for key and value sizes in single get requests.How was this PR tested?
Added unit tests
Does this PR introduce any user-facing changes?