Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] use new getRealTimeTopicName API - part-2 #1386

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

arjun4084346
Copy link
Contributor

@arjun4084346 arjun4084346 commented Dec 11, 2024

This is the continuation work of #1345 and #1349
Changing references for Version::composeRealTimeTopic to Utils::getRealTimeTopicName. Because there are too many references to review easily.

Change references for Version::composeRealTimeTopic to Utils::getRealTimeTopicName

Resolves #XXX

How was this PR tested?

existing tests cover the change

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

@arjun4084346 arjun4084346 marked this pull request as draft December 11, 2024 16:45
@arjun4084346 arjun4084346 force-pushed the rttopicname-part-3 branch 2 times, most recently from 218d116 to e458d65 Compare December 11, 2024 17:26
@arjun4084346 arjun4084346 changed the title add rt topic name in store config [controller] use new getRealTimeTopicName API - part-2 Dec 11, 2024
@arjun4084346 arjun4084346 marked this pull request as ready for review December 11, 2024 17:55
Copy link
Contributor

@lluwm lluwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arjun4084346 arjun4084346 merged commit 26edffc into linkedin:main Dec 12, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants