Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Move RecordTransformer tests from DaVinciClientTest to DaVinciClientRecordTransformerTest #1390

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

kvargha
Copy link
Contributor

@kvargha kvargha commented Dec 12, 2024

Summary, imperative, start upper case, don't end with a period

The E2E DVRT tests take a significant amount of time. To speed up the CI, this PR moves it to its own test file and GitHub workflow.

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

Copy link
Collaborator

@sushantmane sushantmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kvargha!

@kvargha kvargha enabled auto-merge (squash) December 12, 2024 21:53
@sushantmane
Copy link
Collaborator

@kvargha - Can you also move Blob transfer tests out of this class?

@kvargha kvargha disabled auto-merge December 12, 2024 22:10
@kvargha kvargha enabled auto-merge (squash) December 12, 2024 22:13
@kvargha kvargha merged commit 49dc236 into linkedin:main Dec 12, 2024
51 checks passed
@kvargha kvargha deleted the kvargha/move-dvrt-e2e-test branch December 12, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants