Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Complete the corresponding consumer action future in SIT close #1391

Merged

Conversation

xunyin8
Copy link
Contributor

@xunyin8 xunyin8 commented Dec 13, 2024

[server] Complete the corresponding consumer action future in SIT close

In SIT internal close we drain the consumer action queue and process DROP_PARTITION and RESET_OFFSET messages. However, when we process them we did not complete their corresponding future. This breaks any logic that are waiting for those futures and create false positive timeout errors.

How was this PR tested?

New unit test

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

In SIT internal close we drain the consumer action queue and process DROP_PARTITION and
RESET_OFFSET messages. However, when we process them we did not complete their corresponding
future. This breaks any logic that are waiting for those futures and create false positive
timeout errors.
@xunyin8 xunyin8 merged commit a15f3c5 into linkedin:main Dec 13, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants