[controller] Add support for gRPC in venice-controller - Part I #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
force-pushed
the
grpc-in-venice-control-plane-basics
branch
3 times, most recently
from
052e0d8 to
fd9b817
Compare
2 tasks
- Add controller handler service and gRPC server with secure mode - Implement create store, get store, getAllStores, list stores APIs - Add proto definitions for Stores and empty push - Enable configuration to toggle gRPC server on/off - Fix error handling and transport in ControllerClient for test compatibility - Add additional routes: AdminCommandExecution, AdminTopicMetadata, Cluster, Version - Update Docker setup for gRPC compatibility Add experimental changes Add integration test
- Add javadoc
sushantmane
force-pushed
the
grpc-in-venice-control-plane-basics
branch
from
fd9b817 to
405b106
Compare
sushantmane
force-pushed
the
grpc-in-venice-control-plane-basics
branch
from
405b106 to
3c79933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for gRPC in venice-controller - Part I
This commit introduces foundational server-side code to support gRPC-based endpoints in the Venice Controller. To keep the change set manageable and facilitate incremental progress, this PR includes only 3 out of the 15 endpoints implemented in #1244. The remaining endpoints will be added in the subsequent PRs.
How was this PR tested?
UTs and E2E tests
Does this PR introduce any user-facing changes?