[router] Made most VeniceRouterConfig fields final #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only two exceptions, related to throttling, which are allowed to be mutated post-init. Miscellaneous: - Deleted a dead config: router.compute.fast.avro.enabled - Made VeniceProperties::getMap return an unmodifiable map.
2 tasks
internal/venice-client-common/src/main/java/com/linkedin/venice/utils/VeniceProperties.java
Show resolved
Hide resolved
|
Thanks Sourav! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are only two exceptions, related to throttling, which are allowed to be mutated post-init.
Miscellaneous:
N.B.: This is a carve out of #1367 to make that other PR smaller. It is the most trivial part of that PR.
How was this PR tested?
New unit tests.
Does this PR introduce any user-facing changes?