[vpj] Improve error handling in VeniceVsonFileIterator and add tests #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sushantmane
changed the title
…ition failures and ensure fileReader is properly initialized. - Improved error messages and logging to include detailed information and stack traces for easier debugging. - Added null check for VeniceVsonRecordReader in the constructor. - Added VeniceVsonFileIteratorTest to test initialization and handle exceptions.
sushantmane
force-pushed
the
fix-npe-in-VeniceVsonFileIterator
branch
from
903e1d6 to
6d0c4bc
Compare
| String errorMessage = | ||
| String.format("Failed to open file: %s. Ensure that the file is a valid sequence file.", hdfsPath.getName()); | ||
| LOGGER.error(errorMessage, e); | ||
| throw new VeniceException(errorMessage, e); |
There was a problem hiding this comment.
Not sure if this is the right thing to do
There was a problem hiding this comment.
Let me check how Avro input works. I'm very surprised this didn't fail for the avro inputs
There was a problem hiding this comment.
It does fail for avro input (non sequence file)
There was a problem hiding this comment.
Not sure if this is the right thing to do
Why? If we can't create fileReader what's the point in continuing with the execution? We can add retries (for non-seq file exception) if we want to have additional layer of protection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NPE in VeniceVsonFileIterator when input file is not SequenceFile
ensure fileReader is properly initialized.
easier debugging.
How was this PR tested?
UT
Does this PR introduce any user-facing changes?