[controller][server] Remove SIT ready-to-serve check for A/A and non-AGG store during L/F transition #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixpluszero
changed the title
KaiSernLim
reviewed
Dec 24, 2024
| && hybridStoreConfig.get().getDataReplicationPolicy().equals(DataReplicationPolicy.AGGREGATE); | ||
| } | ||
|
|
||
| ReadyToServeCheck getReadyToServerChecker() { |
There was a problem hiding this comment.
Suggested change
| ReadyToServeCheck getReadyToServerChecker() { | |
| ReadyToServeCheck getReadyToServeChecker() { |
You must've been typing 'server' too much.
| && !setStore.activeActiveReplicationEnabled) { | ||
| throw new VeniceHttpException( | ||
| HttpStatus.SC_BAD_REQUEST, | ||
| "Hybrid store config invalid. Cannot have incremental push enabled while A/A not enabled", |
There was a problem hiding this comment.
Some failing tests will need to be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[server] Remove SIT ready-to-serve check for A/A and non-AGG store during L/F transition
Ready-to-serve check happens in two threads today:
(1) Drainer: which is reasonable
(2) SIT thread: there are two sub-cases:
Also, I noticed that there are a bunch of integration tests which enables incremental push on NON-AA store. This is totally invalid setup and after removing the additional RTS check, these tests start to fail/very flaky.
To make sure we don't do this in test and prod, this PR added a new check in update store command in parent controller, which will fail loudly if the new update request is to set incremental push to be true on a non-A/A store.
I have another thinking about enabling all the configs that are enabled in production to be enabled in the test suite, but I'd like to do it in another separate PR, so it is easier for reviewers.
Beyonds that, fixed a flaky unit test that can throw NPE.
How was this PR tested?
Add a sinlge unit test.
Does this PR introduce any user-facing changes?