Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Merge field-level props when generating superset schema #693

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[controller] Merge field-level props when generating superset schema #693

merged 2 commits into from
Nov 30, 2023

Conversation

gaojieliu
Copy link
Contributor

Summary, imperative, start upper case, don't end with a period

Merge field-level props when generating superset schema

How was this PR tested?

CI

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to explain your proposed changes and call out the behavior change.

sixpluszero
sixpluszero approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@sixpluszero sixpluszero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to clarify on this: Is any existing use case using field level props and we are missing it already? I guess Frame is going to move from file level props to field level props, but not sure if it is why you make this change.

...al/venice-client-common/src/main/java/com/linkedin/venice/utils/AvroSupersetSchemaUtils.java Show resolved Hide resolved
...nice-client-common/src/test/java/com/linkedin/venice/schema/TestAvroSupersetSchemaUtils.java Show resolved Hide resolved
@gaojieliu gaojieliu force-pushed the fix_superset_schema_prop branch from 2b04244 to 24038db Compare November 30, 2023 00:03
@gaojieliu gaojieliu merged commit 227f46c into linkedin:main Nov 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixpluszero sixpluszero sixpluszero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaojieliu @sixpluszero