Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc-templates folder for jinja templates #13

Closed
wants to merge 1 commit into from

Conversation

sujaypatil96
Copy link
Member

Addresses issue #10

Copy link
Collaborator

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this locally? If it works then I think this looks good!

@sujaypatil96
Copy link
Member Author

It does work, but @cmungall is concerned that keeping the jinja templates https://github.com/linkml/linkml/tree/main/linkml/generators/docgen bundled with core linkml and the jinja templates here in this repo in sync will be challenging, which makes sense. What do you think?

Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's hold off for now until we have decided on the full lifecycle of the jinja

I think it's OK to make more technical people jump through the hoops of copying the files manually, as they will need technical expertise to edit the local jinja anyway

@cmungall cmungall closed this Sep 20, 2022
@sujaypatil96 sujaypatil96 deleted the doc-templates-jinja branch May 11, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants