Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1627 #279

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Issue 1627 #279

merged 2 commits into from
Sep 14, 2023

Conversation

pkalita-lbl
Copy link
Contributor

@pkalita-lbl pkalita-lbl commented Sep 14, 2023

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 73.85% and project coverage change: +0.20% 🎉

Comparison is base (74d699c) 65.86% compared to head (b04b0e3) 66.06%.
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   65.86%   66.06%   +0.20%     
==========================================
  Files          56       60       +4     
  Lines        7613     7700      +87     
  Branches     2012     2021       +9     
==========================================
+ Hits         5014     5087      +73     
- Misses       2009     2024      +15     
+ Partials      590      589       -1     
Files Changed Coverage Δ
linkml_runtime/linkml_model/validation.py 0.00% <0.00%> (ø)
linkml_runtime/loaders/loader_root.py 69.84% <54.28%> (+3.17%) ⬆️
linkml_runtime/dumpers/rdf_dumper.py 65.90% <55.55%> (-5.89%) ⬇️
linkml_runtime/utils/context_utils.py 73.77% <60.00%> (+5.43%) ⬆️
linkml_runtime/loaders/delimited_file_loader.py 82.85% <82.85%> (ø)
linkml_runtime/dumpers/json_dumper.py 77.77% <84.61%> (-1.54%) ⬇️
linkml_runtime/loaders/yaml_loader.py 92.30% <85.71%> (+1.00%) ⬆️
linkml_runtime/utils/schemaview.py 87.79% <88.88%> (ø)
linkml_runtime/dumpers/delimited_file_dumper.py 89.65% <89.65%> (ø)
linkml_runtime/dumpers/__init__.py 100.00% <100.00%> (ø)
... and 12 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pkalita-lbl pkalita-lbl changed the title WIP: Issue 1627 Issue 1627 Sep 14, 2023
@pkalita-lbl pkalita-lbl marked this pull request as ready for review September 14, 2023 19:14
@pkalita-lbl
Copy link
Contributor Author

@cmungall Can you double-check that these changes are still inline with what you were doing in #248

@pkalita-lbl pkalita-lbl merged commit a0f393c into main Sep 14, 2023
8 checks passed
@pkalita-lbl pkalita-lbl deleted the issue-1627 branch September 14, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemaView raises exception when loading remote import on Windows
2 participants