-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first draft conversion of unittest syntax to pytest syntax for schema… #328
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 63.44% 63.37% -0.07%
==========================================
Files 63 63
Lines 8942 8942
Branches 2569 2569
==========================================
- Hits 5673 5667 -6
- Misses 2648 2653 +5
- Partials 621 622 +1 ☔ View full report in Codecov by Sentry. |
prereq: linkml/linkml-model#201 |
…on't include it in the range_expression, else do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the behaviour of the tests --
test_induced_range_expression_with_range()
test_induced_range_only_range()
test_induced_range_only_range_expression()
I tried to review the code but I can't say that I've understood it fully. Just a quick question, similar to any_of
and exactly_one_of
do we need to implement special handling for none_of
or all_of
?
…view tests.