convert schemaview unittests to pytest #343
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 63.62% 63.43% -0.20%
==========================================
Files 63 63
Lines 8966 8982 +16
Branches 2572 2574 +2
==========================================
- Hits 5705 5698 -7
- Misses 2643 2665 +22
- Partials 618 619 +1 ☔ View full report in Codecov by Sentry. |
Makefile
Outdated
| poetry run python -m unittest discover | ||
| poetry run pytest |
There was a problem hiding this comment.
I think you should be able to remove poetry run python -m unittest discover. Pytest knows how to run unittest-based tests, so I believe what's here would end up running unittest-based tests twice.
tests/test_utils/test_schemaview.py
Outdated
|
|
||
| def test_children_method(self): | ||
| def test_children_method(): | ||
| view = SchemaView(SCHEMA_NO_IMPORTS) |
There was a problem hiding this comment.
You don't need to redefine view in all these test functions since you made a fixture for it. Just include view or schema_view_no_imports as an argument to the function.
There was a problem hiding this comment.
yep, makes sense. Some of the tests redefine the import to test components of importing but not this. Fixed (I replaced the new SchemaView initialization with the fixture but left the view variable assignment in place because not doing so would mean many more test changes.)
No description provided.