-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.13, Remove python 3.8 #345
Open
sneakers-the-rat
wants to merge
10
commits into
linkml:main
Choose a base branch
from
sneakers-the-rat:python-3.13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneakers-the-rat
changed the title
python 3.13 update
Add python 3.13, Remove python 3.8
Oct 9, 2024
… bunch of actually used imports
…cation warning we actually have no way of keeping track of that.
This was referenced Oct 15, 2024
Silvanoc
reviewed
Oct 28, 2024
caufieldjh
approved these changes
Nov 18, 2024
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sibling of: linkml/linkml#2358
Fix: linkml/linkml#2370
does what it says on the tin.
Currently linkml/linkml#2358 is failing because there's a
from typing import re
statement in here, so i also removed that.I added the upgrade ruff rules and one to check for unused imports just to automate the update, and i figure why the heck not leave them in here i would actually really like to at least isort stuff in here if not give it the same linting rules as upstream.
Other stuff
kwargs
in dataclasses - if we want to keep this in then someone else re-implement it, but the basis for doing that was removed in python 3.13 and it seems like the thing it was supposed to do (report line numbers from instantiation errors) is better done at yaml loading time rather than object instantiation time to me, since the only time it would work anyway is after yaml has been loaded with the loader that would be able to report the error in the first place.whitelist_externals
rather thanallowlist_externals
) so i fixed them to just work with normal standards-compliant installation rather than wrestle with accursed poetry, but i can take that out if it's not wanted.__all__
tolinkml_runtime.linkml_model
because importing'*'
from it makes linters complain.dict -> model_dump
andparse_obj -> model_validate
, which i swear i have done like 20 times but it keeps showing up somehow lol__test__ = False
flag toTestEnvironment
so pytest doesn't try to treat it like a test.