Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update smoke test coverage and improve nightly test workflow #452

Merged

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Aug 28, 2024

📝 Description

This PR updates smoke test coverage and improve nightly smoke test workflow:

  • Test coverage updated
  • Added option to test specific branch with sha input
  • Added slack notifications at end of nightly smoke test workflow

e.g.
image

✔️ How to Test

make smoketest
Forked run -https://github.com/ykim-1/linode_api4-python/actions/runs/10602495345

Failures not related to this PR

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Aug 28, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner August 28, 2024 02:36
@ykim-akamai ykim-akamai requested review from jriddle-linode and ezilber-akamai and removed request for a team August 28, 2024 02:36
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and tests are passing locally! Is there a way for me to verify that the Slack notifications are working properly?

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

@ykim-akamai
Copy link
Contributor Author

Changes look good and tests are passing locally! Is there a way for me to verify that the Slack notifications are working properly?

Slack application finally got approved and installed on slack workspace today. Will be posting the update in the team channel shortly

@ykim-akamai ykim-akamai merged commit e2b8c46 into linode:dev Sep 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants