Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing LDE argument to disk_create #456

Merged

Conversation

ezilber-akamai
Copy link
Contributor

@ezilber-akamai ezilber-akamai commented Sep 12, 2024

📝 Description

Added disk_encryption argument to disk_create to prevent it from being interpreted as stackscript_args.

✔️ How to Test

Unit Tests

make testunit

Integration Tests

pytest test/integration/models/linode/test_linode.py -k test_linode_create_disk

@ezilber-akamai ezilber-akamai requested a review from a team as a code owner September 12, 2024 19:12
@ezilber-akamai ezilber-akamai requested review from jriddle-linode and zliang-akamai and removed request for a team September 12, 2024 19:12
@ezilber-akamai ezilber-akamai changed the title fix: Added missing LDE param to disk_create fix: Added missing LDE argument to disk_create Sep 12, 2024
@ykim-akamai ykim-akamai requested review from a team, ykim-akamai and yec-akamai and removed request for a team September 12, 2024 19:24
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are passing locally. Thanks for the quick fix!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@ezilber-akamai ezilber-akamai merged commit e4214f4 into linode:dev Sep 12, 2024
7 checks passed
@ezilber-akamai ezilber-akamai added the bugfix for any bug fixes in the changelog. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix for any bug fixes in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants