test: Add cloud firewalls to migration tests and improve wait times to disk related tests #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rewall to migration test
ykim-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
|
Just a heads up to any onlookers, the linting failures will be fixed by #461 |
ykim-akamai
requested review from
lgarber-akamai,
a team,
zliang-akamai and
yec-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Sep 24, 2024
zliang-akamai
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds cloud firewall to migration tests and also add safety around wait times for disk related tests
Note skipping migration tests for now due to
400: [region] The selected region is not capable of disk encryption at this time.✔️ How to Test
make TEST_CASE="test_disk_resize_and_duplicate" testintmake TEST_CASE="test_linode_initate_migration" testint📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.