Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix slack payload in integration workflow #464

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Sep 27, 2024

📝 Description

Needed to use job status instead of step outcome
e.g.

"text": "*Build Result:*\n${{ steps.integration_tests.outcome == 'success' && ':large_green_circle: Build Passed' || ':red_circle: Build Failed' }}"

Instead need to use,

"text": "*Build Result:*\n${{ needs.integration_tests.result == 'success' && ':large_green_circle: Build Passed' || ':red_circle: Build Failed' }}"

✔️ How to Test

Tested on forked repo - https://github.com/ykim-1/linodego/actions/runs/11075403223

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai requested a review from a team as a code owner September 27, 2024 18:13
@ykim-akamai ykim-akamai requested review from zliang-akamai and yec-akamai and removed request for a team September 27, 2024 18:13
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@ykim-akamai ykim-akamai merged commit 6fcc069 into linode:dev Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants