Add include_none_values ClassVar to JSONObject; apply to response-only classes #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
requested review from
zliang-akamai,
ezilber-akamai and
yec-akamai
and removed request for
a team and
zliang-akamai
ezilber-akamai
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds a new
include_none_valuesClassVar to the JSONObject base class, which allows child classes to globally configure whether their fields should explicitly be included in their.dictoutputs.Additionally, this pull request enables this functionality on the response classes updated in #459, which should prevent a breaking change in the next release.
NOTE: This change has been validated against the ansible_linode
lke_cluster_acltest.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Integration Testing