Configure default Python version using integration-tests job environment #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
added
the
repo-ci-improvement
lgarber-akamai
requested review from
yec-akamai and
ezilber-akamai
and removed request for
a team
ykim-akamai
approved these changes
Nov 12, 2024
|
Thank you for the fix! |
yec-akamai
reviewed
Nov 12, 2024
.github/workflows/e2e-test.yml
Outdated
| @@ -28,11 +27,14 @@ on: | |||
| - main | |||
| - dev | |||
|
|
|||
| env: | |||
| DEFAULT_PYTHON_VERSION: "3.10" | |||
| EOL_PYTHON_VERSION: "3.9" | |||
There was a problem hiding this comment.
It seems 3.9 is not officially EOL now. Is it okay to leave it as it is?
There was a problem hiding this comment.
Good call! I just pushed up a commit with the adjusted versions; this probably needs to be applied to the other Python repos too 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request fixes a small issue that caused runs triggered by pushes to dev and main to not resolve a valid Python version, leading to a failure. This works by moving the default and EOL Python versions to the job-level environment rather than in the
workflow_dispatchinput defaults.Sample Runs:
Run EOL python version?set to true✔️ How to Test
Manual Testing
Run EOL python version?set to true