Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update helpers, fix flaky tests, and refactor for consistency #476

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Nov 14, 2024

📝 Description

In effort to stabilize the test runs in GHA, I updated few test functions and tests as well as generally refactoring for consistency. Here are few points are addressed in this PR:

  • Marked and improved flaky tests
  • Refactored some test functions in helpers.py
  • Updated all test labels and regions
  • Re-enable disk encryption tests

✔️ How to Test

make testint

Run on PR - https://github.com/linode/linode_api4-python/actions/runs/11845761094

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Nov 14, 2024
@ykim-akamai ykim-akamai requested a review from a team as a code owner November 14, 2024 20:46
@ykim-akamai ykim-akamai requested review from yec-akamai and ezilber-akamai and removed request for a team November 14, 2024 20:46
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing locally. Nice work!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice test improvement!

@ykim-akamai ykim-akamai merged commit 0987f21 into linode:dev Nov 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants