Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to crossplane v1.16 and enable MR metrics #232

Closed
wants to merge 1 commit into from
Closed

Conversation

nolancon
Copy link
Collaborator

@nolancon nolancon commented May 16, 2024

Description of your changes

Update Crossplnae to v1.16.0 and enable new metrics introduced in crossplane/crossplane-runtime#683.

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Run make ceph-chainsaw to validate these changes against Ceph. This step is not always necessary. However, for changes related to S3 calls it is sensible to validate against an actual Ceph cluster. Localstack is used in our CI Chainsaw suite for convenience and there can be disparity in S3 behaviours betwee it and Ceph. See docs/TESTING.md for information on how to run tests against a Ceph cluster.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually test and view the newly exposed metrics

  • Port forward Provider Ceph pod port 8080
    k -n crossplane-system port-forward <provider-ceph-pod-name> 8080:8080
  • Curl to metrics endpoint
    curl -s http://localhost:8080/metrics
# HELP certwatcher_read_certificate_errors_total Total number of certificate read errors
# TYPE certwatcher_read_certificate_errors_total counter
certwatcher_read_certificate_errors_total 0
# HELP certwatcher_read_certificate_total Total number of certificate reads
# TYPE certwatcher_read_certificate_total counter
certwatcher_read_certificate_total 1
# HELP controller_runtime_active_workers Number of currently used workers per controller
# TYPE controller_runtime_active_workers gauge
controller_runtime_active_workers{controller="managed/bucket.provider-ceph.ceph.crossplane.io"} 0
controller_runtime_active_workers{controller="providerconfig"} 0
controller_runtime_active_workers{controller="providerconfig/providerconfig.ceph.crossplane.io"} 0
# HELP controller_runtime_max_concurrent_reconciles Maximum number of concurrent reconciles per controller
# TYPE controller_runtime_max_concurrent_reconciles gauge
controller_runtime_max_concurrent_reconciles{controller="managed/bucket.provider-ceph.ceph.crossplane.io"} 160
controller_runtime_max_concurrent_reconciles{controller="providerconfig"} 5
controller_runtime_max_concurrent_reconciles{controller="providerconfig/providerconfig.ceph.crossplane.io"} 160
# HELP controller_runtime_reconcile_errors_total Total number of reconciliation errors per controller
# TYPE controller_runtime_reconcile_errors_total counter
controller_runtime_reconcile_errors_total{controller="managed/bucket.provider-ceph.ceph.crossplane.io"} 0
controller_runtime_reconcile_errors_total{controller="providerconfig"} 0
controller_runtime_reconcile_errors_total{controller="providerconfig/providerconfig.ceph.crossplane.io"} 0
# HELP controller_runtime_reconcile_time_seconds Length of time per reconciliation per controller
# TYPE controller_runtime_reconcile_time_seconds histogram
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.005"} 0
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.01"} 15
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.025"} 16
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.05"} 16
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.1"} 16
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.15"} 16
controller_runtime_reconcile_time_seconds_bucket{controller="managed/bucket.provider-ceph.ceph.crossplane.io",le="0.2"} 16

@nolancon nolancon marked this pull request as ready for review May 20, 2024 09:12
@nolancon nolancon requested review from mhmxs and Shunpoco and removed request for mhmxs and Shunpoco May 20, 2024 09:12
@nolancon nolancon marked this pull request as draft May 20, 2024 11:14
@nolancon nolancon closed this Sep 11, 2024
nolancon added a commit that referenced this pull request Oct 3, 2024
* Bump to crossplane v1.16 and enable MR metrics

* Update go version and build submodule

* Bump golangci-lint version

* Fix unsafe conversion caught by updated linter

* Bump govulncheck version

* update go version in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant