Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COLOR_SCHEME when commands exit with error #58

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix COLOR_SCHEME when commands exit with error #58

merged 1 commit into from
Oct 4, 2023

Conversation

TheTumultuousUnicornOfDarkness
Copy link
Collaborator

Fix #57

@TheTumultuousUnicornOfDarkness TheTumultuousUnicornOfDarkness mentioned this pull request Oct 1, 2023
Closed
TheAssassin
TheAssassin requested changes Oct 4, 2023
View reviewed changes
Copy link
Member

@TheAssassin TheAssassin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether a single line feed character could cause any issues. We should likely just use an empty string.

linuxdeploy-plugin-gtk.sh Outdated Show resolved Hide resolved
@TheAssassin
Copy link
Member

Thanks! Please feel free to merge once the test issues are resolved.

@TheTumultuousUnicornOfDarkness
Copy link
Collaborator Author

@TheAssassin please hold CI is not passing.

@TheAssassin
Copy link
Member

You may have to really use printf, I think this is pretty portable.

@TheTumultuousUnicornOfDarkness
Copy link
Collaborator Author

You may have to really use printf, I think this is pretty portable.

Yeah, I forgot that echo -n is not POSIX compliant... Better with printf ''. All good now.
Thank you for the review.

@TheTumultuousUnicornOfDarkness TheTumultuousUnicornOfDarkness merged commit 3b67a1d into master Oct 4, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAssassin TheAssassin TheAssassin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After commit 'Prefer color-scheme from...' generated AppImage won't start
2 participants
@TheTumultuousUnicornOfDarkness @TheAssassin