Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep upload and download artifacts actions versions up to date #2

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

alex-spataru
Copy link
Contributor

Hi!

First of all, thank you so much for your hard work on the linuxdeploy project. I use it extensively in my CI builds to generate releases for my Linux users, and it's been a real time-saver (especially with Qt 6 apps).

Today, I came across this repository and wanted to give it a try. Many of my users have requested that I provide Debian and RPM packages, and I believe the solution implemented by this plugin is exactly what I need. So far, I've successfully built a functional *.deb package in my CI pipeline, and I'm still working on getting *.rpm packages to build properly.

While testing, I forked the repository to add some debug logging to help troubleshoot an issue. During the process, I encountered a failure in the CI workflow due to the use of deprecated versions of the upload and download artifact actions. More details on this deprecation can be found here.

To resolve the issue, I updated the actions to their latest version (v4), which fixed the problem and allowed the workflow to pass successfully. Hope you find this fix useful.

Thanks again for all your work on this project!

-- Alex Spataru

@TheAssassin
Copy link
Member

TheAssassin commented Nov 6, 2024

Thank you for the kind works and your contribution. I've just updated some other repositories with the same changes.

The documentation is very sparse unfortunately. The first (public) real-world use case will hopefully be AppImageLauncher.

@TheAssassin TheAssassin merged commit 8d817c6 into linuxdeploy:main Nov 6, 2024
2 checks passed
@alex-spataru
Copy link
Contributor Author

Thank you for the kind works and your contribution.

Thank you so much! I’m glad to help and give back to the projects I depend on!

The documentation is very sparse, unfortunately. The first (public) real-world use case will hopefully be AppImageLauncher.

I was able to troubleshoot the issue — it turns out I just needed to run the plugin on an Ubuntu 22.04 runner instead of Ubuntu 20.04. On my local machine (OpenSUSE Leap), both the RPM and DEB packaging worked seamlessly. For reference, here’s an example action script I’m currently using. It’s a bit of a tangle since it targets macOS, Windows, and Linux in the same workflow and does not make use of a build matrix, but it gets the job done! 😄

Also, the project I’m using this plugin with has an active user base, so it could be helpful for identifying any issues in the current implementation. This might provide some real-world feedback before integrating the plugin into AppImageLauncher.

Let me know if I can help with any documentation or fixes that might be required!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants