Keep upload and download artifacts actions versions up to date #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thank you so much for your hard work on the
linuxdeploy
project. I use it extensively in my CI builds to generate releases for my Linux users, and it's been a real time-saver (especially with Qt 6 apps).Today, I came across this repository and wanted to give it a try. Many of my users have requested that I provide Debian and RPM packages, and I believe the solution implemented by this plugin is exactly what I need. So far, I've successfully built a functional
*.deb
package in my CI pipeline, and I'm still working on getting*.rpm
packages to build properly.While testing, I forked the repository to add some debug logging to help troubleshoot an issue. During the process, I encountered a failure in the CI workflow due to the use of deprecated versions of the upload and download artifact actions. More details on this deprecation can be found here.
To resolve the issue, I updated the actions to their latest version (
v4
), which fixed the problem and allowed the workflow to pass successfully. Hope you find this fix useful.Thanks again for all your work on this project!
-- Alex Spataru