fix: incorrect icon for app running in a separate pid namespace #11907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reproduce the issue described, and I'm concerned disabling this will affect other programs. Please provide more info - what distribution, cinnamon and webapp-manager version mainly. |
|
Linux Mint 21.2 Please take a look at the window-info.txt It's really hard to reproduce. Happens with Chromium and Goland only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
With grouped-window-list, keep 'Group windows by application' off.
Run Chromium in a separate pid namespace. Chromium gets pid 2. (In my case firejail and 'ip netns' are used.)
Run another app in another pid namespace. It gets pid 2 too.
Sometimes the icon of this app in the grouped-window-list is replaced with the Chromium's icon, quite often after closing and opening a new window.
After examining the window properties of the two apps above, I find their _NET_WM_PID are both 2, and this makes get_app_from_window_pid() return the same CinnamonApp.