Use Polkit agent for X11 sessions #12272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkyBluefang
commented
Jul 3, 2024
Comment on lines
+396
to
+461
| if(!(err instanceof Error)) { | ||
| err = new Error(err); | ||
| } | ||
|
|
||
| log('polkitAuthenticationAgent: init error ' + err); | ||
|
|
||
| let icon = new St.Icon({ icon_name: 'dialog-warning', | ||
| icon_type: St.IconType.FULLCOLOR, | ||
| icon_size: 36 }); | ||
|
|
||
| Main.warningNotify(_('Unable to start Cinnamon PolicyKit Agent'), err.message + | ||
| "\n\n" + | ||
| _("If you have another PolicyKit Agent configured to autostart, it should be disabled."), | ||
| icon); |
There was a problem hiding this comment.
This was my best guess at how to handle this. I wasn't sure if it belonged here or in main.js
|
Fedora already switched to internal polkit agent also for xorg, probably @leigh123linux can tell you how it's going and if he has encountered any problems |
|
No one has complained yet about the switch to internal polkit, 6.2.x was promoted to F40 stable the other day. |
|
If that's the case, then maybe this is closer to prime time than I thought :) |
|
This probably shouldn't be merged currently. Part of the reason we don't use this dialog is because it doesn't support multiple users yet. It's something I'm looking at adding this development cycle. Maybe should revisit the idea then. |
4 tasks
SparkyBluefang
force-pushed
the
polkit-agent-on-x11
branch
from
c6402be
to
02203ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies packaging since we don't need to worry if an external polkit agent is needed. This is currently a draft since I understand upstream may not be ready for this change yet. But I'm creating this now so I can reference it in Gentoo packaging.
Also, don't crash if the agent doesn't start properly. If another agent happens to be running, this will throw a DBus exception. I figured popping a notification would be most appropriate, since the user may have another agent configured to auto-start.