Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check schema keys before accessing them #15

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Check schema keys before accessing them #15

merged 3 commits into from
Jul 26, 2024

Conversation

whot
Copy link
Member

@whot whot commented Jul 26, 2024

This fixes the current issues with stylus ... show when running on GNOME 46 or earlier. The newly supported keys (#12 and #9) don't exist yet, causing a crash.

whot added 3 commits July 26, 2024 10:54
@whot
pyproject: don't warn about asserts
c455076
@whot
Settings always has a Gio.Settings field
0605776 
This is never None, so remove that type annotation
@whot
Better wrap our Gio.Settings in our Settings class
8a95fce 
This allows us for checking if keys on the schema exist so we don't fail
with newer gsetwacom running on older gnome versions where some keys
may not exist.

Fixes: 5fe1b32 ("Support stylus keybindings")
Fixes: 99ca77f ("Add support for pressure ranges")
@whot whot merged commit 21a2e57 into linuxwacom:main Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@whot