CHORE Update address range constructor (#145)

linxGnu · Mar 21, 2024 · 7ddd965 · 7ddd965
1 parent 1d156d8
commit 7ddd965
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/pdu/AddressRange.go b/pdu/AddressRange.go
@@ -15,10 +15,10 @@ func NewAddressRange() AddressRange {
 }
 
 // NewAddressRangeWithAddr create new AddressRange.
-func NewAddressRangeWithAddr(addr string) (a AddressRange, err error) {
-	a = NewAddressRange()
-	a.AddressRange = addr
-	return
+func NewAddressRangeWithAddr(addr string) AddressRange {
+	ar := NewAddressRange()
+	ar.AddressRange = addr
+	return ar
 }
 
 // NewAddressRangeWithTonNpi create new AddressRange with ton, npi.
@@ -27,10 +27,10 @@ func NewAddressRangeWithTonNpi(ton, npi byte) AddressRange {
 }
 
 // NewAddressRangeWithTonNpiAddr returns new address with ton, npi, addr string.
-func NewAddressRangeWithTonNpiAddr(ton, npi byte, addr string) (a AddressRange, err error) {
-	a = NewAddressRangeWithTonNpi(ton, npi)
-	a.AddressRange = addr
-	return
+func NewAddressRangeWithTonNpiAddr(ton, npi byte, addr string) AddressRange {
+	ar := NewAddressRangeWithTonNpi(ton, npi)
+	ar.AddressRange = addr
+	return ar
 }
 
 // Unmarshal from buffer.

diff --git a/pdu/AddressRange_test.go b/pdu/AddressRange_test.go
@@ -8,16 +8,10 @@ import (
 
 func TestAddressRange(t *testing.T) {
 	t.Run("new", func(t *testing.T) {
-		a, err := NewAddressRangeWithAddr("abc")
-		require.NoError(t, err)
+		a := NewAddressRangeWithAddr("abc")
 		require.Equal(t, "abc", a.AddressRange)
 	})
 
-	t.Run("newWithAddr", func(t *testing.T) {
-		_, err := NewAddressRangeWithAddr("12345678901234567890121234567890123456789012")
-		require.NoError(t, err)
-	})
-
 	t.Run("newTonNpi", func(t *testing.T) {
 		a := NewAddressRangeWithTonNpi(3, 7)
 		a.AddressRange = "123456789"
@@ -27,8 +21,7 @@ func TestAddressRange(t *testing.T) {
 	})
 
 	t.Run("newTonNpiAddr", func(t *testing.T) {
-		a, err := NewAddressRangeWithTonNpiAddr(3, 7, "123456789")
-		require.NoError(t, err)
+		a := NewAddressRangeWithTonNpiAddr(3, 7, "123456789")
 		require.EqualValues(t, 3, a.Ton)
 		require.EqualValues(t, 7, a.Npi)
 		require.Equal(t, "123456789", a.AddressRange)