-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix diff changelog generating undesired changes #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
changed the title
fix: backing index should not be unique
fix: backing index should issues for liquibase-hibernate
Apr 12, 2024
src/main/java/liquibase/ext/hibernate/diff/ChangedUniqueConstraintChangeGenerator.java
Dismissed
Show resolved
Hide resolved
filipelautert
changed the title
fix: backing index should issues for liquibase-hibernate
fix: backing index unique changes should be ignored
Apr 12, 2024
src/main/java/liquibase/ext/hibernate/diff/ChangedPrimaryKeyChangeGenerator.java
Dismissed
Show dismissed
Hide dismissed
filipelautert
changed the title
fix: backing index unique changes should be ignored
fix diff changelog generating undesired changes
Apr 19, 2024
tati-qalified
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with:
- Unique constraints
- Indexes
- Sequences
Works as expected!
Now, should we backport it to hibernate5 ? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hibernate doesn't know about all the variations that occur with primary keys/sequences/unique constrains, especially backing index stuff.
To prevent unexpected changesets to be generated we suppress this kind of changes.
PR liquibase/liquibase#5792 also helps.