use testcontainers' @Container annotation
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so far we started the testcontainer manually. however, [the official way][quickstart] is to use the `@Testcontainers` and `@Container` annotations. the major difference in behaviour between the two is that in our existing setup we started one container for all tests together, so they could influence each other, while the new setup launches a new container for each test. the downside of this is that test execution now takes longer as it always needs to spin up a new container and wait for OpenSearch to start. as we don't have that many tests this should be acceptable and the improved stability is probably worth it. [quickstart]: https://java.testcontainers.org/quickstart/junit_5_quickstart/
|
reta
approved these changes
Nov 14, 2024
filipelautert
approved these changes
Nov 18, 2024
filipelautert
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far we started the testcontainer manually. however, the official way is to use the
@Testcontainersand@Containerannotations.the major difference in behaviour between the two is that in our existing setup we started one container for all tests together, so they could influence each other, while the new setup launches a new container for each test. the downside of this is that test execution now takes longer as it always needs to spin up a new container and wait for OpenSearch to start. as we don't have that many tests this should be acceptable and the improved stability is probably worth it.