Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix integration tests execution #78

Merged
merged 3 commits into from
Nov 21, 2024
Merged

chore: fix integration tests execution #78

merged 3 commits into from
Nov 21, 2024

Conversation

filipelautert
Copy link
Contributor

No description provided.

rursprung
rursprung requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@rursprung rursprung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real fix is that you need to run this:

git update-index --chmod=+x ./mvnw

and then commit that

can you please also fix the name of the integration tests? i missed it in the previous PR.

name: Integration Test - Java ${{ matrix.java }}

.github/workflows/test.yml Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@filipelautert filipelautert merged commit 300c125 into master Nov 21, 2024
22 of 24 checks passed
@filipelautert filipelautert deleted the fix-integration-tests branch November 21, 2024 14:25
@rursprung rursprung mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rursprung rursprung rursprung approved these changes

Assignees
No one assigned
Labels
skipReleaseNotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipelautert @rursprung