conformity on isotp_user.h #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to compile with C++ compilers, it's common practice to offer extern "C" on a makro basis. All C-based system includes of Linux do so. I suggest to do it likewise here. Another thing is to `#include <stdint.h>`. The problem is that some compilers often automatically export names defined in various headers or provided types before such standards were in place. Details can be found here: https://stackoverflow.com/questions/11069108/uint32-t-does-not-name-a-type
|
It seems this repo doesn't get much attention from its author any more. I'd be glad to include your change in my fork though, if you don't mind. |
|
Sure |
|
Branches have been merged |
|
great, have you got a link to your fork? |
|
https://github.com/SimonCahill/isotp-c <-- right there |
driftregion
pushed a commit
to driftregion/isotp-c
that referenced
this pull request
Aug 15, 2024
Moved link time build options out of compile time options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to compile with C++ compilers, it's common practice to offer extern "C" on a makro basis. All C-based system includes of Linux do so. I suggest to do it likewise here.
Another thing is to
#include <stdint.h>. The problem is that some compilers often automatically export names defined in various headers or provided types before such standards were in place.Details can be found here: https://stackoverflow.com/questions/11069108/uint32-t-does-not-name-a-type