Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tasks doc #1044

Merged
merged 11 commits into from
Oct 9, 2023
Merged

Add Tasks doc #1044

merged 11 commits into from
Oct 9, 2023

Conversation

justinfagnani
Copy link
Contributor

@justinfagnani justinfagnani commented Feb 10, 2023 •
edited by AndrewJakubowicz
Loading

Fixes: #1191

Adds Task docs to 3.0.

@github-actions
Copy link

github-actions bot commented Feb 10, 2023 •
edited
Loading

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1044-7a5df01---lit-dev-5ftespv5na-uc.a.run.app/docs/v3/data/task/
https://pr1044-f169aa2---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1044-d893d77---lit-dev-5ftespv5na-uc.a.run.app/

e111077
e111077 requested changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry know it's still in draft but I have some suggestions

packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/data/task.md Outdated Show resolved Hide resolved
@justinfagnani justinfagnani mentioned this pull request Aug 15, 2023
Closed
justinfagnani and others added 4 commits August 17, 2023 13:53
@justinfagnani
Merge branch 'main' into task-doc
820ae58
@justinfagnani
More updates
d6f1cfb
@justinfagnani
Update docs link on labs page
c4de225
@augustjk
Updates
1e31935 
- Remove labs reference
- Make samples switchable where needed
- Minor formatting
@augustjk augustjk changed the base branch from main to 3.0 September 29, 2023 22:34
@augustjk augustjk changed the title WIP: Draft of Tasks doc Add Tasks doc Sep 29, 2023
@augustjk augustjk marked this pull request as ready for review September 29, 2023 22:34
AndrewJakubowicz
AndrewJakubowicz approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are awesome! Great stuff!
A couple minor comments, and change the example imports to use the graduated package.

packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/libraries/labs.md Outdated Show resolved Hide resolved
e111077
e111077 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@e111077 e111077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much time to review this, so don't count my review as blocking!

@AndrewJakubowicz AndrewJakubowicz changed the base branch from 3.0 to main October 9, 2023 16:23
@AndrewJakubowicz AndrewJakubowicz requested review from rictic and augustjk and removed request for sorvell October 9, 2023 16:36
augustjk
augustjk approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo

packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
packages/lit-dev-content/site/docs/v3/data/task.md Outdated Show resolved Hide resolved
@AndrewJakubowicz AndrewJakubowicz merged commit 7f21f41 into main Oct 9, 2023
13 of 15 checks passed
@AndrewJakubowicz AndrewJakubowicz deleted the task-doc branch October 9, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimdetroyer wimdetroyer wimdetroyer left review comments

@augustjk augustjk augustjk approved these changes

@AndrewJakubowicz AndrewJakubowicz AndrewJakubowicz approved these changes

@e111077 e111077 e111077 approved these changes

@rictic rictic rictic approved these changes

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.0] Update graduated labs package documentation
6 participants
@justinfagnani @rictic @e111077 @AndrewJakubowicz @augustjk @wimdetroyer