Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add async task playground example #1179

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Aug 31, 2023

Repurposed the existing but hidden async task example to use @lit-labs/task.

We can add additional examples with future PRs.

direct preview link: https://pr1179-c068b7f---lit-dev-5ftespv5na-uc.a.run.app/playground/#sample=examples/async-task

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1179-cd4bc80---lit-dev-5ftespv5na-uc.a.run.app/
https://pr1179-c068b7f---lit-dev-5ftespv5na-uc.a.run.app/

@augustjk augustjk marked this pull request as ready for review August 31, 2023 23:25
- Split out npm helpers to separate file
- Find npm logo svg from web
- Reorder some things
Copy link
Contributor

@justinfagnani justinfagnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@@ -0,0 +1,77 @@
import {LitElement, css, html} from 'lit';
import {customElement, state} from 'lit/decorators.js';
import {Task} from '@lit-labs/task';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update this for graduation. cc @rictic

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Played with the demo in the preview & it's extremely nice! Thank you and great example!

@augustjk augustjk merged commit a64d3a2 into main Sep 1, 2023
15 checks passed
@augustjk augustjk deleted the task-playground branch September 1, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants