Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip site to v3 as the latest Lit version #1194
Flip site to v3 as the latest Lit version #1194
Changes from 15 commits
2ecb43d
afe6d3c
7822fe3
a99b233
122d941
8397b8f
d5dad64
40a659a
e3c91e0
bb2819e
d62010c
4cf06f7
eb87cc4
f472667
d20fa0f
5bba8c4
621d05f
bb7b3fd
5ebef4f
9f89b43
a57125f
038bde5
5d04289
a10b2b6
293c49d
5c75033
a67c41c
6bdefec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous phrasing hedged things a bit, can we keep expectations in check with a range? Maybe "While not all templates will see rendering performance improvements from compilation, on our "template heavy" benchmark we measured..."