-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Learn] Land the learn page #1258
Conversation
A live preview of this PR will be available at the URL(s) below. https://pr1258-85e6dbd---lit-dev-5ftespv5na-uc.a.run.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🏫 🚀
Co-authored-by: Augustine Kim <[email protected]>
Now that the article page is navigable, check links is failing on the hidden links to tags.
We should just not render them at all until it's available by commenting out: lit.dev/packages/lit-dev-content/site/_includes/article.html Lines 10 to 16 in 397df96
|
Oh no.. the link checker thinks
We may need to explicitly bypass this here lit.dev/packages/lit-dev-tests/src/check-redirects.ts Lines 83 to 91 in f3febcf
|
@augustjk Thank you for the redirect tip. I've added a small workaround so that we pass the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land it!! Hype!
Fixes: #822
Context
"Land" the Learn catalog page. This PR does not remove the tutorials page, as that page is still valuable for the tutorials collection.
Changes
Tutorials
->Learn
./tutorials
->/learn#filter=tutorial
.Test plan
Added a smoke test integration test, which renders the tutorial catalog.