[infra] update Lit and the Lit eleventy plugin #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. |
|
Looks like this naive upgrade resulted in duplicated Lit which is creating property minifaction errors in the eleventy lit plugin. |
AndrewJakubowicz
force-pushed
the
update-eleventy-lit
branch
from
83edd62 to
5f998ef
Compare
augustjk
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue: #1269
Context
Instead of updating Lit to 3 at once, this change updates us to the latest version of Lit 2. The change to Lit 3 will follow.
I also updated the
@lit-labs/eleventy-plugin-litto pull in the module resolution change.Why pin
@lit-labs/ssrto 3.1.9?I naively updated
@lit-labs/ssrto3.2., however this introduces compiled templates and requiresLit 3. This pulled in a duplicated Lit 3 into SSR which is incompatible with Lit 2 during SSR – causing CI to fail.Fixed by deduping
litand not updating it completely. Will update it with Lit 3.Test plan
Bugs in the Lit upgrade should be caught in the playground or screenshot tests. I tested preview link manually.
Bugs in
eleventy-plugin-litwould result in catastrophic build errors. Tested locally & also covered by checking preview link.