Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve localize documentation #1280

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Improve localize documentation #1280

merged 1 commit into from
Dec 14, 2023

Conversation

julienvier
Copy link
Contributor

Add localeCodesModule in lit-localize.json

@augustjk
Copy link
Member

/gcbrun

augustjk
augustjk approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
Technically it's an optional config but all of our examples do use it as good practice for keeping the locales in code in sync with those listed in the config so this seems fine to add.

@augustjk augustjk merged commit bc5c21a into lit:main Dec 14, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustjk augustjk augustjk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienvier @augustjk