[docs] Update CDN suggestion in lit-html v1 docs #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. https://pr1299-e485353---lit-dev-5ftespv5na-uc.a.run.app/ |
augustjk
commented
Jan 18, 2024
packages/lit-dev-content/site/docs/v1/lit-html/getting-started.md
Outdated
Show resolved
Hide resolved
justinfagnani
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still have a section that points to unpkg.com using
?modulewhich has trouble with modern JS syntax. See lit/lit#4316 and linked issues in unpkg repo.Since this is in the old v1 doc, we can also suggest the version be pinned.. but opted to just provide alternative CDNs.