Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(controllers): remove needless non-null assertion operator #1306

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

maxpatiiuk
Copy link
Contributor

This PR fixes a small issue in the docs:

  • a needless non-nullish assertion (since the this.task property is assigned in the constructor, ! is not necessary)

Btw, I really like Lit controllers! I am primarily working with Stencil, and the need for code reuse lead me to create a pattern I called "Stencil Controllers" - that was before I knew that Lit had a very similar feature, with a very similar name - what a coincidence!

Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Could you also make the same change to packages/lit-dev-content/samples/v3-docs/controllers/names/names-controller.ts?
We have copies of docs for v2 and v3 and this change can apply to both versions.

@maxpatiiuk maxpatiiuk requested a review from augustjk February 17, 2024 01:53
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@augustjk augustjk merged commit f0aa0ef into lit:main Feb 27, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants