-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more details to the TypeScript docs #1346
Conversation
A live preview of this PR will be available at the URL(s) below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -202,12 +202,23 @@ For full installation and usage instructions, see the [Web Dev Server documentat | |||
|
|||
## TypeScript { #typescript } | |||
|
|||
TypeScript extends the Javascript language by adding support for types. Types are useful for catching errors early and making code more readable and understandable. | |||
Lit support developing components in TypeScript, including full type declarations for the Lit APIs, standard and experimental decorators, and community tools for template type-checking and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supports*
also I think differentiating between decorators isn’t totally relevant here esp since we tackle that later. Maybe focus a bit more on “it also supports TS” might help be a bit more concise here
TypeScript extends the Javascript language by adding support for types. Types are useful for catching errors early and making code more readable and understandable. | ||
Lit support developing components in TypeScript, including full type declarations for the Lit APIs, standard and experimental decorators, and community tools for template type-checking and linting. | ||
|
||
Because Lit is just a library, and doesn't require a compiler or use non-standard langauge syntax, there are no specific TypeScript tools that are required. Lit works with the official TypeScript compiler, `tsc`, with TypeScript wrappers such as those for Rollup, Vite, or Webpack, and alternate compilers like `esbuild`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify to reader what you’re implying by “just a library”
Oops it’s merged |
I can make those changes though! |
We hadn't mentioned what's required from a TypeScript config in this section yet.