This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Handling attachments #118
Open
Handling attachments #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see: #117
Now the handling of attachments would be much more consistent.
Besides what mentioned in the issue above, I've converted supported message subtypes from a method to a constant, to make it easier for people extend it with a "bot_message" subtype when it's necessary. I totally agree that this should not be a default behaviour of this slack adapter, but I can imagine a case when it's necessary to monkey patch it, for example as a temporary solution.