feat: Implement a FunctionView. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCardin
force-pushed
the
dc/function-view
branch
3 times, most recently
from
e0d9749
to
a5b8157
Compare
DanCardin
force-pushed
the
dc/function-view
branch
from
a5b8157
to
a912b70
Compare
peterschutt
reviewed
Aug 14, 2024
DanCardin
force-pushed
the
dc/function-view
branch
from
a912b70
to
947a2c6
Compare
DanCardin
commented
Aug 15, 2024
DanCardin
commented
Aug 15, 2024
DanCardin
force-pushed
the
dc/function-view
branch
3 times, most recently
from
83ac746
to
4ffd2a5
Compare
peterschutt
reviewed
Aug 16, 2024
@peterschutt Just wanted to point out we'll support 3.8 in Litestar beyond its EOL, specifically to cover evidently's use case, so dropping 3.8 would mean we definitely can't adopt. But I'm with you, I don't think we would be able to before 3.0 anyway. |
DanCardin
force-pushed
the
dc/function-view
branch
6 times, most recently
from
8534cb1
to
b33ea80
Compare
DanCardin
force-pushed
the
dc/function-view
branch
from
b33ea80
to
f96749c
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/type-lens-docs-preview/23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_type_hintsin order to have practical use forParameterViewTo be clear, this whole impl is in-flux, while I try to actually apply it to cappa, to make sure it's usable.The current API seems to be usable in cappa, and works in place of the the existing usages ofget_type_hintsandinspect.signature