Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative path for outputs #586

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Use relative path for outputs #586

merged 1 commit into from
Aug 9, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Aug 9, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

⚠️ No Changeset found

Latest commit: 2e9dbe4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO requested a review from Ocupe August 9, 2023 07:00
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

size-limit report 📦

Path Size
LiveKitRoom only 1.88 KB (0%)
LiveKitRoom with VideoConference 28.85 KB (0%)
All exports 39.68 KB (0%)

Ocupe
Ocupe approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍
A brief explanation or link to the docs would be nice to have some context in the future. :)

@lukasIO
Copy link
Contributor Author

lukasIO commented Aug 9, 2023

yeah sorry, it was a warning being logged when running a command

@lukasIO lukasIO merged commit fa3060b into main Aug 9, 2023
2 checks passed
@lukasIO lukasIO deleted the lukas/fix-output branch August 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocupe Ocupe Ocupe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasIO @Ocupe