Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css var for idle visualizer bar color #985

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add css var for idle visualizer bar color #985

merged 2 commits into from
Sep 26, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Sep 25, 2024

No description provided.

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: b5cc35c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@livekit/components-styles Patch
@livekit/component-example-next Patch
@livekit/component-docs-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size
LiveKitRoom only 1.91 KB (0%)
LiveKitRoom with VideoConference 28.87 KB (0%)
All exports 35.72 KB (0%)

Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the default colors to be a faint gray rather than a translucent white, so it's not invisible on a white bg. right now the experience of dropping this into a project with a white bg is pretty confusing, since you need to open the inspector to see if it even worked. cc @mattherzog

@lukasIO lukasIO merged commit 6609b09 into main Sep 26, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/va-styling branch September 26, 2024 13:14
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants