Fix race when playing dial tones. (#228)

livekit · Nov 18, 2024 · 44fe89c · 44fe89c
1 parent 5a05221
commit 44fe89c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/pkg/sip/outbound.go b/pkg/sip/outbound.go
@@ -294,7 +294,13 @@ func (c *outboundCall) dialSIP(ctx context.Context) error {
 		go func() {
 			rctx, span := tracer.Start(rctx, "tones.Play")
 			defer span.End()
-			tones.Play(rctx, c.lkRoomIn, ringVolume, tones.ETSIRinging)
+			c.mu.RLock()
+			dst := c.lkRoomIn
+			c.mu.RUnlock()
+			if dst == nil {
+				return
+			}
+			tones.Play(rctx, dst, ringVolume, tones.ETSIRinging)
 		}()
 	}
 	err := c.sipSignal(ctx)