Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass peer IP to IO service in a type-safe way. #204

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Oct 16, 2024

No description provided.

@dennwc dennwc self-assigned this Oct 16, 2024
@dennwc dennwc requested a review from a team as a code owner October 16, 2024 12:11
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.01%. Comparing base (c7fd4ad) to head (e54dec9).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/sip/inbound.go 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   66.24%   66.01%   -0.24%     
==========================================
  Files          50       51       +1     
  Lines        5659     6455     +796     
==========================================
+ Hits         3749     4261     +512     
- Misses       1576     1823     +247     
- Partials      334      371      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennwc dennwc merged commit 391c715 into main Oct 16, 2024
2 of 3 checks passed
@dennwc dennwc deleted the sip-safe-ip-checks branch October 16, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants