Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable call ID reuse across auth attempts #229

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Disable call ID reuse across auth attempts #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57eaefb
try not reusing callid
biglittlebigben Nov 19, 2024
7c129ad
Disable call ID reuse across auth attempts
biglittlebigben Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/sip/outbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,10 @@ func (c *sipOutbound) attemptInvite(ctx context.Context, prev *sip.Request, dest
ctx, span := tracer.Start(ctx, "sipOutbound.attemptInvite")
defer span.End()
req := sip.NewRequest(sip.INVITE, to.Address)
if prev != nil {

const reuseCallID = false // FIXME some service may require the call ID to be kept between auth attempts, but Telnyx requires it to change

if reuseCallID && prev != nil {
if cid := prev.CallID(); cid != nil {
req.RemoveHeader("Call-ID")
req.AppendHeader(cid)
Expand Down
Loading